Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(account): fix failing team tests #1405

Merged
merged 1 commit into from
Oct 23, 2023
Merged

test(account): fix failing team tests #1405

merged 1 commit into from
Oct 23, 2023

Conversation

Serpentiel
Copy link
Contributor

About this change—what it does

fixes failing team test

Why this way

to make them work

@Serpentiel Serpentiel added bug Something isn't working no changelog No changelog entries are required for this PR labels Oct 22, 2023
@Serpentiel Serpentiel requested a review from a team October 22, 2023 21:46
@Serpentiel Serpentiel changed the title test(account): fix filing team tests test(account): fix failing team tests Oct 22, 2023
ivan-savciuc
ivan-savciuc suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing the account as an organization under the hood is not a good idea. We should request a change of permissions for our CI projects to test the same API and underlying logic that our customers do, those who are stuck with the accounts, and we have most such customers right now.

@Serpentiel
Copy link
Contributor Author

this never replaced anything with an organization, its simply an env variable name, because the entity was renamed from account to organization, but as you can see, under the hood it uses aiven_account data source

@Serpentiel
Copy link
Contributor Author

acceptance tests (ignore everything except account): https://github.com/aiven/terraform-provider-aiven/actions/runs/6609605992/job/17950010317

@Serpentiel Serpentiel force-pushed the aleks-test-account-fix-failing-team-tests branch from f0f6742 to 20ad53a Compare October 23, 2023 06:44
@Serpentiel
Copy link
Contributor Author

@mhoffm-aiven thanks for helping to set things up from the CI side of things 🥂

@Serpentiel Serpentiel force-pushed the aleks-test-account-fix-failing-team-tests branch from 20ad53a to 436b2f0 Compare October 23, 2023 06:58
@Serpentiel Serpentiel force-pushed the aleks-test-account-fix-failing-team-tests branch from 436b2f0 to 63a9cae Compare October 23, 2023 06:59
ivan-savciuc
ivan-savciuc approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan-savciuc ivan-savciuc merged commit 70ba3fd into main Oct 23, 2023
10 checks passed
@ivan-savciuc ivan-savciuc deleted the aleks-test-account-fix-failing-team-tests branch October 23, 2023 07:14
Serpentiel added a commit that referenced this pull request Oct 25, 2023
@Serpentiel
test(account): fix failing team tests (#1405)
065ee1f 
(cherry picked from commit 70ba3fd)
Serpentiel added a commit that referenced this pull request Oct 25, 2023
@Serpentiel
test(account): fix failing team tests (#1405)
55df653 
(cherry picked from commit 70ba3fd)
Serpentiel added a commit that referenced this pull request Oct 26, 2023
@Serpentiel
test(account): fix failing team tests (#1405)
20b7fb5 
(cherry picked from commit 70ba3fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-savciuc ivan-savciuc ivan-savciuc approved these changes

Assignees

@ivan-savciuc ivan-savciuc

Labels
bug Something isn't working no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serpentiel @ivan-savciuc