fix: user config marshal error omitted #1392

byashimov · 2023-10-13T08:38:42Z

About this change—what it does

Some errors has been omitted because of diags vs error approaches

internal/plugin/service/serviceintegration/userconfig.go

ivan-savciuc

LGTM

byashimov added the no changelog No changelog entries are required for this PR label Oct 13, 2023

byashimov force-pushed the byashimov-fix-userconfig-marshal branch 6 times, most recently from 7e11d79 to 3009b1e Compare October 13, 2023 09:11

byashimov commented Oct 13, 2023

View reviewed changes

internal/plugin/service/serviceintegration/userconfig.go Show resolved Hide resolved

byashimov force-pushed the byashimov-fix-userconfig-marshal branch from 3009b1e to 0638c6b Compare October 13, 2023 09:16

byashimov marked this pull request as ready for review October 13, 2023 09:19

byashimov requested a review from a team October 13, 2023 09:19

fix: user config marshal error omitted

873f478

byashimov force-pushed the byashimov-fix-userconfig-marshal branch from 0638c6b to 873f478 Compare October 13, 2023 14:34

ivan-savciuc approved these changes Oct 16, 2023

View reviewed changes

ivan-savciuc enabled auto-merge (squash) October 16, 2023 07:14

ivan-savciuc merged commit 58b884d into main Oct 16, 2023
10 checks passed

ivan-savciuc deleted the byashimov-fix-userconfig-marshal branch October 16, 2023 08:13

Serpentiel assigned ivan-savciuc Oct 16, 2023

Serpentiel pushed a commit that referenced this pull request Nov 6, 2023

fix: user config marshal error omitted (#1392)

c3f4742