Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): use set instead of list #1382

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(plugin): use set instead of list #1382

merged 1 commit into from
Oct 6, 2023

Conversation

byashimov
Copy link
Contributor

About this change—what it does

Uses set instead of list type.

@byashimov byashimov added the no changelog No changelog entries are required for this PR label Oct 5, 2023
@byashimov byashimov force-pushed the byashimov-generate-set branch 2 times, most recently from 9055e6a to 2aba1ad Compare October 5, 2023 12:32
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review October 5, 2023 18:15
@byashimov byashimov requested a review from a team October 5, 2023 18:15
@byashimov byashimov force-pushed the byashimov-generate-set branch from 2aba1ad to 5532dfb Compare October 6, 2023 11:18
Serpentiel
Serpentiel approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Oct 6, 2023
@Serpentiel Serpentiel merged commit f707c99 into main Oct 6, 2023
10 checks passed
@Serpentiel Serpentiel deleted the byashimov-generate-set branch October 6, 2023 11:31
@Serpentiel Serpentiel added the enhancement New feature or request label Oct 6, 2023
Serpentiel pushed a commit that referenced this pull request Nov 6, 2023
@byashimov @Serpentiel
feat(plugin): use set instead of list (#1382)
ccaab18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel