Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): add missing read timeout #1374

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

byashimov
Copy link
Contributor

About this change—what it does

Adds read timeout option. Resolves #1072 for v3.

@byashimov byashimov added the bug Something isn't working label Oct 2, 2023
@byashimov byashimov changed the base branch from main to v3 October 2, 2023 14:12
@byashimov byashimov marked this pull request as ready for review October 2, 2023 14:12
@byashimov byashimov requested a review from a team October 2, 2023 14:12
@byashimov byashimov force-pushed the byashimov-add-read-timeout branch from 5dc0240 to 6467319 Compare October 2, 2023 14:13
@byashimov byashimov force-pushed the byashimov-add-read-timeout branch from 6467319 to 552d49a Compare October 2, 2023 14:14
@byashimov byashimov changed the title fix: add read timeout fix(service): add missing read timeout Oct 2, 2023
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Oct 2, 2023
@Serpentiel Serpentiel merged commit 8195b66 into v3 Oct 2, 2023
9 checks passed
@Serpentiel Serpentiel deleted the byashimov-add-read-timeout branch October 2, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrading to v3.13.0 or higher fails when having aiven_kafka_topic resources with read timeout
2 participants