-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): allow protobuf schema #1369
Conversation
38f3a0e
to
176f225
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only proposition of my would be to use a go-protobuf library for validation and normalization
176f225
to
4f49dc4
Compare
002c58e
to
450a5e7
Compare
450a5e7
to
d3980d1
Compare
so what do you suggest changing it with then? I checked, it works just fine as long as the string looks like we need some kind of validation in this place to be able to combine it together with the existing JSON validation mechanic |
d3980d1
to
60e27fa
Compare
@byashimov I've updated the PR with the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
About this change—what it does
allows usage of
protobuf
schema in Kafka resourcesresolves #1366
Why this way
we would want to have this feature in place