Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg): allow to modify user replication settings #1364

Merged

Conversation

Serpentiel
Copy link
Contributor

About this change—what it does

allows to modify pg_user replication settings

resolves #1362

Why this way

this is long ago supported by the API

@Serpentiel Serpentiel added the enhancement New feature or request label Sep 19, 2023
@Serpentiel Serpentiel requested a review from a team September 19, 2023 21:33
@Serpentiel Serpentiel force-pushed the aleks-feat-pg-allow-to-modify-user-replication-settings branch from 2e37e12 to 9b64fd7 Compare September 19, 2023 21:46
@Serpentiel Serpentiel force-pushed the aleks-feat-pg-allow-to-modify-user-replication-settings branch from 9b64fd7 to 0f88700 Compare September 19, 2023 21:48
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I have a question

internal/sdkprovider/service/pg/pg_user.go Show resolved Hide resolved
@Serpentiel Serpentiel enabled auto-merge (squash) September 20, 2023 18:23
@Serpentiel Serpentiel added the skip workflows Skips workflows execution for this PR label Sep 20, 2023
@Serpentiel Serpentiel self-assigned this Sep 20, 2023
@Serpentiel Serpentiel merged commit c78cc4e into main Sep 20, 2023
17 of 18 checks passed
@Serpentiel Serpentiel deleted the aleks-feat-pg-allow-to-modify-user-replication-settings branch September 20, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request skip workflows Skips workflows execution for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiven_pg_user resource should not replace user when enabling replication
2 participants