Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kafka_topic): add KafkaTopic repository #1349

Merged
merged 1 commit into from
Nov 15, 2023
Merged

refactor(kafka_topic): add KafkaTopic repository #1349

merged 1 commit into from
Nov 15, 2023

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Sep 8, 2023 •
edited
Loading

About this change—what it does

Adds new KafkaTopic repository, benefits:

  • unit testable (by using client interfaces instead of real client)
  • gathers all GET requests from tf resources running parallel into a batch request, and returns topics on channels immediately
  • incapsulates retries and backend issues

@byashimov byashimov added the no changelog No changelog entries are required for this PR label Sep 8, 2023
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch 17 times, most recently from fddb2aa to b207496 Compare September 11, 2023 10:42
@byashimov byashimov changed the title refactor(kafka_topic): add KafkaTopic repository refactor(kafkatopic): add KafkaTopic repository Sep 11, 2023
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch from b207496 to d84db10 Compare September 11, 2023 11:17
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov added the enhancement New feature or request label Sep 11, 2023
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch 8 times, most recently from 3e2c3c4 to 37b7ad9 Compare September 16, 2023 19:39
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch from 0d0e15a to 7b95ca7 Compare September 20, 2023 13:18
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch from 7b95ca7 to 5b8df24 Compare September 28, 2023 09:45
@byashimov byashimov marked this pull request as ready for review September 28, 2023 09:46
@byashimov byashimov requested a review from a team September 28, 2023 09:46
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch 2 times, most recently from eb0c082 to ae0e1b8 Compare September 28, 2023 09:47
Serpentiel
Serpentiel previously requested changes Oct 2, 2023
View reviewed changes
internal/sdkprovider/kafkatopicrepository/create_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/create_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/create_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/create_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/create_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/repository_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/repository_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/repository_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/repository_test.go Show resolved Hide resolved
internal/sdkprovider/kafkatopicrepository/repository_test.go Outdated Show resolved Hide resolved
@Serpentiel Serpentiel self-assigned this Oct 2, 2023
@Serpentiel
Copy link
Contributor

please address the conflicts in go.mod, too

@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch from ae0e1b8 to 70fc043 Compare October 18, 2023 10:47
@byashimov byashimov changed the base branch from main to v4 November 6, 2023 11:38
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch from 70fc043 to d16d624 Compare November 8, 2023 19:56
@byashimov byashimov changed the base branch from v4 to main November 8, 2023 19:56
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch 3 times, most recently from 451a50e to b10e187 Compare November 8, 2023 20:36
@byashimov byashimov changed the title refactor(kafkatopic): add KafkaTopic repository refactor(kafka_topic): add KafkaTopic repository Nov 8, 2023
@byashimov byashimov force-pushed the byashimov-add-kafka-topic-repository branch 3 times, most recently from d5b15ad to 36617aa Compare November 13, 2023 11:22
ivan-savciuc
ivan-savciuc reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Serpentiel
Serpentiel suggested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please respond to each comment, currently it's not clear what has been improved in the PR, and what was skipped

Serpentiel
Serpentiel approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel force-pushed the byashimov-add-kafka-topic-repository branch from 36617aa to 78433b7 Compare November 15, 2023 11:03
@Serpentiel Serpentiel enabled auto-merge (squash) November 15, 2023 11:03
@Serpentiel Serpentiel merged commit 4da7e87 into main Nov 15, 2023
10 checks passed
@Serpentiel Serpentiel deleted the byashimov-add-kafka-topic-repository branch November 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-savciuc ivan-savciuc ivan-savciuc left review comments

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byashimov @Serpentiel @ivan-savciuc