statsd: aggregate metrics from a chunk in batch #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process all metrics in a chunk together. This is necessary for custom Prometheus-like histogram metrics. For example, when creating an `http_response_duration_seconds` metric with buckets 1...100 and a flush interval in Telegraf set to 30 seconds, the old version of the code would process each sample separately. If a flush interval occurred, only the processed metrics would be flushed with the current timestamp. The next metrics would be flushed in the following interval with a different timestamp (+30s), causing issues with histogram calculation. In the current version, all samples are processed together.
ezotrank
force-pushed
the
kremenev/statsd-batch-v1.32.0
branch
from
88cd0d9 to
983389e
Compare
Base automatically changed from
kremenev/telegraf-v1.32.0
to
aiven-release-v1.32.0
October 15, 2024 12:37
RommelLayco
approved these changes
Oct 16, 2024
|
We should really be making changes upstream and not in our fork. Leads to maintenance nightmare. |
|
Ideally we could get these changes merged upstream and get our fork closer to head of upstream cause we are lagging. |
facetoe
requested changes
Oct 17, 2024
We already have a nightmare to sync with upstream (#144) :sadcat: but I agree, that things might be good for others it should be pushed to upstream, and I'm already working on it, but it needs some time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process all metrics in a chunk together.
This is necessary for custom Prometheus-like histogram metrics. For example, when creating an
http_response_duration_secondsmetric with buckets 1...100 and a flush interval in Telegraf set to 30 seconds, the old version of the code would process each sample separately. If a flush interval occurred, only the processed metrics would be flushed with the current timestamp. The next metrics would be flushed in the following interval with a different timestamp (+30s), causing issues with histogram calculation. In the current version, all samples are processed together.Required for all PRs
resolves #