mirrormaker: restrict the number of checkpoint connector tasks #61
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-mm2-limit-checkpoint-connector-task-number
branch
from
ba30302 to
bd88077
Compare
gharris1727
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
This is a configuration problem specific to dedicated mode, so I'm not sure it makes sense to add this as a connector configuration.
I would have expected this to be a modification in MirrorMakerConfig#connectorBaseConfig, so that the real "tasks.max" configuration is changed.
Both ultimately fix the problem, so this is just a style nit.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-mm2-limit-checkpoint-connector-task-number
branch
2 times, most recently
from
2516dd5 to
a648a21
Compare
…or tasks The MirrorCheckpointConnector uses the global tasks max for setting the number of maximum tasks. This can cause extreme burden on single Kafka broker when hundreds of checkpoint tasks are consuming from from the single partition topic. The default is set to 1 and is configurable.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-mm2-limit-checkpoint-connector-task-number
branch
from
a648a21 to
e4ffdad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MirrorCheckpointConnector uses the global tasks max for setting the number of maximum tasks. This can cause extreme burden on single Kafka broker when hundreds of checkpoint tasks are consuming from from the single partition topic.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)