Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add out enum types #29

Merged
merged 1 commit into from
Mar 14, 2024
Merged

refactor: add out enum types #29

merged 1 commit into from
Mar 14, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Mar 1, 2024 •
edited
Loading

Adds Out enum types to use them in comparisons, e.g.

if s.Status == service.ServiceStateTypeRunning {
    ....
}

@byashimov byashimov force-pushed the byashimov-add-out-enums branch 4 times, most recently from e988d15 to 3867481 Compare March 1, 2024 14:37
@byashimov byashimov marked this pull request as ready for review March 1, 2024 15:01
@byashimov byashimov requested a review from a team March 1, 2024 15:01
@byashimov byashimov force-pushed the byashimov-add-out-enums branch 5 times, most recently from 0b6b031 to 53e5d38 Compare March 1, 2024 15:39
@Serpentiel Serpentiel self-assigned this Mar 1, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Mar 1, 2024
Serpentiel
Serpentiel previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) March 1, 2024 15:46
@byashimov byashimov force-pushed the byashimov-add-out-enums branch from 53e5d38 to 8c8c1a9 Compare March 1, 2024 16:05
@byashimov byashimov disabled auto-merge March 1, 2024 16:05
@byashimov byashimov marked this pull request as draft March 1, 2024 16:07
@byashimov byashimov force-pushed the byashimov-add-out-enums branch 4 times, most recently from 140556f to 039cbaf Compare March 1, 2024 16:17
@byashimov byashimov marked this pull request as ready for review March 5, 2024 04:55
@byashimov byashimov force-pushed the byashimov-add-out-enums branch from 039cbaf to e79f913 Compare March 14, 2024 09:32
@Serpentiel Serpentiel merged commit 3d3e22a into main Mar 14, 2024
6 checks passed
@Serpentiel Serpentiel deleted the byashimov-add-out-enums branch March 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel