Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): convert multierror to err #12

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(logger): convert multierror to err #12

merged 1 commit into from
Feb 13, 2024

Conversation

byashimov
Copy link
Contributor

Multi-error passes nil check, yet it is empty.

@byashimov byashimov force-pushed the byashimov-fix-initial-bugs branch 2 times, most recently from 21c30ad to 227c7b0 Compare February 13, 2024 09:19
@byashimov byashimov marked this pull request as ready for review February 13, 2024 09:19
@byashimov byashimov requested a review from a team February 13, 2024 09:19
@Serpentiel Serpentiel self-assigned this Feb 13, 2024
Serpentiel
Serpentiel approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel added the enhancement New feature or request label Feb 13, 2024
@Serpentiel Serpentiel force-pushed the byashimov-fix-initial-bugs branch from 227c7b0 to 38dd61f Compare February 13, 2024 11:19
@Serpentiel Serpentiel enabled auto-merge (squash) February 13, 2024 11:19
@Serpentiel Serpentiel added bug Something isn't working and removed enhancement New feature or request labels Feb 13, 2024
@Serpentiel Serpentiel force-pushed the byashimov-fix-initial-bugs branch from 38dd61f to 223d74a Compare February 13, 2024 11:22
@Serpentiel Serpentiel merged commit 7143146 into main Feb 13, 2024
6 checks passed
@Serpentiel Serpentiel deleted the byashimov-fix-initial-bugs branch February 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel