Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve errors #117

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: improve errors #117

merged 1 commit into from
Aug 22, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Aug 22, 2024 •
edited
Loading

  • Doesn't log json response body, which might contain sensitive data
  • Logs non-json bodies
  • Improves Error: message and errors fields takes values from failed response
  • Adds query params to logs
  • Removes IsNilOrNotFound - useless

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2024
View reviewed changes
error.go Fixed Show fixed Hide fixed
@byashimov byashimov force-pushed the byashimov-improve-errors branch from d89ebe0 to 87f284b Compare August 22, 2024 09:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2024
View reviewed changes
error.go Fixed Show fixed Hide fixed
@byashimov byashimov force-pushed the byashimov-improve-errors branch 4 times, most recently from c7f1a97 to 40559d5 Compare August 22, 2024 10:12
@byashimov byashimov changed the title feat: improve logging feat: improve errors Aug 22, 2024
@byashimov byashimov force-pushed the byashimov-improve-errors branch from 40559d5 to 3d0bd76 Compare August 22, 2024 10:36
@byashimov byashimov force-pushed the byashimov-improve-errors branch from 3d0bd76 to dc86e24 Compare August 22, 2024 10:42
@byashimov byashimov marked this pull request as ready for review August 22, 2024 10:42
@byashimov byashimov requested a review from a team as a code owner August 22, 2024 10:42
@byashimov byashimov merged commit f6f7a60 into main Aug 22, 2024
6 checks passed
@byashimov byashimov deleted the byashimov-improve-errors branch August 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski