This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howto content Flink Custom JARs application #2361
Howto content Flink Custom JARs application #2361
Changes from all commits
8ac5446
c360be1
6ca0085
f43e5db
e72172a
5449cb8
93f3900
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 4 in docs/products/flink/howto/create-flink-applications.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-flink-applications.rst#L4
Raw output
Check failure on line 4 in docs/products/flink/howto/create-flink-applications.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-flink-applications.rst#L4
Raw output
Check failure on line 1 in docs/products/flink/howto/create-jar-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-jar-application.rst#L1
Raw output
Check failure on line 37 in docs/products/flink/howto/create-jar-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-jar-application.rst#L37
Raw output
Check failure on line 39 in docs/products/flink/howto/create-jar-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-jar-application.rst#L39
Raw output
Check failure on line 49 in docs/products/flink/howto/create-jar-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-jar-application.rst#L49
Raw output
Check failure on line 49 in docs/products/flink/howto/create-jar-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-jar-application.rst#L49
Raw output
Check failure on line 1 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L1
Raw output
Check failure on line 8 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L8
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the spirit of value and word economy, do we need this note? Are we anticipating user questions for this? (same question for the next note too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would yes for now. It addresses a potential point of confusion for new users who might see the import table option in their first application despite having no other applications to import from. In an ideal scenario, the import option would be disabled or not visible for a user's first application to prevent this confusion.
While we haven't received reports of any issues, we want to preemptively clarify any potential questions or confusion by including this note.
Check failure on line 52 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L52
Raw output
Check failure on line 54 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L54
Raw output
Check failure on line 54 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L54
Raw output
Check failure on line 60 in docs/products/flink/howto/create-sql-application.rst
GitHub Actions / vale
[vale] docs/products/flink/howto/create-sql-application.rst#L60
Raw output
This file was deleted.