This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
[Schedule merge 19.12] Feature/use aws #1577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md Update README.md Update README.md Update README.md
Ugbot
reviewed
Dec 15, 2022
Ugbot
reviewed
Dec 15, 2022
Ugbot
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added two comments around default postrgess ports vs passing them and an env variable,
also around the PG insert, From what ive seen around Aiven, this should be using a PG function not a direct query. Neither of these are blocking issues assuming you've tested the PG stuff, and are sure around Aiven Dev policy on PG functions vs queries.
angelinekwan
approved these changes
Dec 16, 2022
hieu-aiven
force-pushed
the
feature/use-aws
branch
from
December 16, 2022 13:44
5c5685f
to
b01cb97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Why
Process for the switch Netlify to Cloudflare Pages
Switch completed