Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Flink kind #848

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: add Flink kind #848

merged 2 commits into from
Nov 21, 2024

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Nov 19, 2024 •
edited
Loading

Adds new kind Flink. Most of the changeset is generated with:

operator-sdk create api --version v1alpha1 --kind Flink --force
operator-sdk create webhook --version v1alpha1 --kind Flink --defaulting --programmatic-validation --conversion

@rriski rriski force-pushed the rriski-flink-support branch from 4986c1c to fdeb5e9 Compare November 19, 2024 08:34
@rriski
Copy link
Contributor Author

rriski commented Nov 19, 2024 •
edited
Loading

tests

@rriski rriski force-pushed the rriski-flink-support branch from fdeb5e9 to ce5b351 Compare November 19, 2024 08:46
@rriski rriski marked this pull request as ready for review November 19, 2024 11:06
@rriski rriski requested a review from a team as a code owner November 19, 2024 11:06
@rriski rriski requested a review from byashimov November 20, 2024 08:18
byashimov
byashimov previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Could you please add an "example", like this one?
It will render then a "usage" block with a beginner callout (create token, etc), and useful commands/examples.
Then someday we can get rid of this page.
The example can be used as a test too, but I leave this up to you.

@rriski rriski dismissed byashimov’s stale review November 21, 2024 08:45

Changes addressed

@byashimov byashimov merged commit d4bf672 into main Nov 21, 2024
7 checks passed
@byashimov byashimov deleted the rriski-flink-support branch November 21, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byashimov byashimov byashimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rriski @byashimov