Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clickhousegrant): revoke known privileges only #787

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix(clickhousegrant): revoke known privileges only #787

merged 2 commits into from
Jul 16, 2024
+558 −480

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Jul 12, 2024 •
edited
Loading

  • Allows to create grants for non-existing table (Clickhouse can do that)
  • Saves the state to revoke only granted privileges.
    Resolves concurrency access to the grants table in Clickhouse.

@byashimov byashimov force-pushed the byashimov-clickhousegrant-state branch 4 times, most recently from 2d0dd1f to 699a066 Compare July 15, 2024 12:19
@byashimov byashimov changed the title fix(clickhousegrant): save state fix(clickhousegrant): revoke known privileges only Jul 15, 2024
@byashimov byashimov force-pushed the byashimov-clickhousegrant-state branch from 699a066 to 7bde427 Compare July 15, 2024 13:18
@byashimov byashimov force-pushed the byashimov-clickhousegrant-state branch from 7bde427 to 26e979d Compare July 15, 2024 13:43
@byashimov byashimov marked this pull request as ready for review July 16, 2024 07:05
@byashimov byashimov requested a review from a team as a code owner July 16, 2024 07:05
@byashimov
Copy link
Contributor Author

Tests https://github.com/aiven/aiven-operator/actions/runs/9940577849

@byashimov byashimov merged commit 59691fa into main Jul 16, 2024
46 checks passed
@byashimov byashimov deleted the byashimov-clickhousegrant-state branch July 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@byashimov