Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clickhouserole): ignore deletion errors #774

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(clickhouserole): ignore deletion errors #774

merged 1 commit into from
Jul 1, 2024
+17 −4

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Jun 28, 2024 •
edited
Loading

Ignore ClickhouseRole, ClickhouseGrant deletion errors

@byashimov byashimov force-pushed the byashimov-fix-clickhouse-role-deletion branch 2 times, most recently from a17eed0 to 97f9cc5 Compare June 30, 2024 19:34
@byashimov byashimov changed the title fix(clickhouserole): ignore database does not exist fix(clickhouserole): ignore deletion errors Jun 30, 2024
@byashimov byashimov force-pushed the byashimov-fix-clickhouse-role-deletion branch from 97f9cc5 to 38a0f35 Compare June 30, 2024 19:40
@byashimov byashimov marked this pull request as ready for review June 30, 2024 19:43
@byashimov byashimov requested a review from a team as a code owner June 30, 2024 19:43
@byashimov byashimov merged commit 7440c96 into main Jul 1, 2024
45 checks passed
@byashimov byashimov deleted the byashimov-fix-clickhouse-role-deletion branch July 1, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski