Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant CA_CERT secret key #729

Merged
merged 1 commit into from
May 8, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented May 7, 2024

Removes redundant CA_CERT secret key for Grafana, OpenSearch, and Clickhouse. Can't be used with these service types

@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review May 7, 2024 13:01
@byashimov byashimov requested a review from a team as a code owner May 7, 2024 13:01
@Serpentiel Serpentiel self-assigned this May 8, 2024
@Serpentiel Serpentiel added the bug Something isn't working label May 8, 2024
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice find

@Serpentiel Serpentiel merged commit 8f2c3d0 into main May 8, 2024
44 checks passed
@Serpentiel Serpentiel deleted the byashimov-remove-cacert-secret branch May 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants