fix(serviceintegration): skip delete if has no id #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceIntegration
instance without id is looped in deletion.The bug appeared in 017d5c5:133 and 017d5c5:137 after refactoring and copy-pasted to the service integration endpoint controller later. Before that, deletion was requested with empty id which produced false positive 404, yet it worked.
While
ServiceIntegrationEndpoint
is not released yet, not mentioning it in the changelog.