Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceintegration): skip delete if has no id #724

Merged
merged 1 commit into from
May 6, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented May 3, 2024

ServiceIntegration instance without id is looped in deletion.
The bug appeared in 017d5c5:133 and 017d5c5:137 after refactoring and copy-pasted to the service integration endpoint controller later. Before that, deletion was requested with empty id which produced false positive 404, yet it worked.
While ServiceIntegrationEndpoint is not released yet, not mentioning it in the changelog.

@byashimov byashimov marked this pull request as ready for review May 3, 2024 10:31
@byashimov byashimov requested a review from a team as a code owner May 3, 2024 10:31
@byashimov byashimov mentioned this pull request May 6, 2024
@byashimov byashimov force-pushed the byashimov-fix-service-integration-deletion branch from 47136c5 to bf829f8 Compare May 6, 2024 09:46
@byashimov byashimov force-pushed the byashimov-fix-service-integration-deletion branch from bf829f8 to 7c58afb Compare May 6, 2024 09:55
@byashimov byashimov enabled auto-merge (squash) May 6, 2024 09:55
@byashimov byashimov merged commit 9e48e09 into main May 6, 2024
7 checks passed
@byashimov byashimov deleted the byashimov-fix-service-integration-deletion branch May 6, 2024 09:57
@Serpentiel Serpentiel added the bug Something isn't working label May 7, 2024
@Serpentiel Serpentiel assigned byashimov and unassigned rriski May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants