ci(tests): add sweeper to destroy resources after test runs #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-held-aiven
force-pushed
the
jeff-held-aiven-sweep-resources
branch
2 times, most recently
from
4919011 to
dc41159
Compare
Serpentiel
previously requested changes
Feb 28, 2024
byashimov
previously requested changes
Feb 29, 2024
jeff-held-aiven
force-pushed
the
jeff-held-aiven-sweep-resources
branch
from
dc41159 to
a88b0a9
Compare
Serpentiel
changed the title
Adds `sweep` target to Makefile, which will run a sweeper to delete resources in a project. This would include: - services that have "test-" as a prefix for their name - service integration endpoints - VPCs This command is primarily useful for CI, as it is used to cleanup resources after a test run, but can be used locally.
jeff-held-aiven
force-pushed
the
jeff-held-aiven-sweep-resources
branch
from
a88b0a9 to
fc6d4f0
Compare
jeff-held-aiven
dismissed stale reviews from byashimov and Serpentiel
Addressed comments
Serpentiel
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
lgtm, @byashimov @jeff-held-aiven I delegate merging to you folks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
sweeptarget to Makefile, which will run a sweeper to delete resources in a project. This would include: