Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tests): fix tests panic #657

Merged
merged 3 commits into from
Feb 29, 2024
Merged

ci(tests): fix tests panic #657

merged 3 commits into from
Feb 29, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Feb 27, 2024 •
edited
Loading

  • Tries to destroy resources even when panics
  • Splits tests into separate jobs, as individual timeouts are not supported in go yet
  • Adds per-test context timeout to end test gracefully
  • Increases the test runner timeout to 30 minutes to let timeouting test finish

@byashimov byashimov force-pushed the byashimov-recover-test-on-panic branch from 1c166dd to 002908e Compare February 27, 2024 15:48
@byashimov
Copy link
Contributor Author

byashimov commented Feb 27, 2024 •
edited
Loading

tests

@byashimov byashimov force-pushed the byashimov-recover-test-on-panic branch 10 times, most recently from a452384 to b7b58b6 Compare February 29, 2024 11:22
@byashimov byashimov force-pushed the byashimov-recover-test-on-panic branch from b7b58b6 to 839dfe7 Compare February 29, 2024 12:03
@byashimov byashimov changed the title refactor(tests): clean artefacts on panic ci(tests): fix tests panic Feb 29, 2024
@byashimov byashimov force-pushed the byashimov-recover-test-on-panic branch from 028b90f to 29c946b Compare February 29, 2024 13:15
@byashimov byashimov force-pushed the byashimov-recover-test-on-panic branch from 29c946b to b2bff69 Compare February 29, 2024 13:20
@byashimov byashimov marked this pull request as ready for review February 29, 2024 16:13
@byashimov byashimov requested a review from a team February 29, 2024 16:13
@Serpentiel Serpentiel added the enhancement New feature or request label Feb 29, 2024
@Serpentiel Serpentiel self-assigned this Feb 29, 2024
Serpentiel
Serpentiel approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel merged commit 2bb7974 into main Feb 29, 2024
41 checks passed
@Serpentiel Serpentiel deleted the byashimov-recover-test-on-panic branch February 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel