Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send kube version in user-agent of aiven API clients #655

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

jeff-held-aiven
Copy link
Contributor

No description provided.

@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-add-kube-version branch from 1bffbd4 to c25efbb Compare February 28, 2024 15:21
controllers/common.go Outdated Show resolved Hide resolved
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-add-kube-version branch from c25efbb to 573cd18 Compare March 1, 2024 08:53
@Serpentiel Serpentiel added the enhancement New feature or request label Mar 1, 2024
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-add-kube-version branch from 573cd18 to 8a6a2dc Compare March 4, 2024 14:59
controllers/common.go Outdated Show resolved Hide resolved
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-add-kube-version branch 2 times, most recently from 93f486d to ad6a2bc Compare March 5, 2024 08:20
rriski
rriski previously approved these changes Mar 5, 2024
Copy link
Contributor

@rriski rriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @rriski mentioned, we need to get rid of the additional definition of the provider version.

We also should make the approach similar to the one in our Terraform Provider, here's how it works:

TL;DR. While I think it's unreasonable to add GoReleaser support in this PR, I think it'll be beneficial for us to define the meaningful operatorVersion in one place only; this could be done by setting the one in suite_test.go to always be a constant string test, like we do over here. This also allows to understand, via the User-Agent, which requests originated from our tests, and which haven't.

@Serpentiel Serpentiel force-pushed the jeff-held-aiven-add-kube-version branch from ad6a2bc to f8b37db Compare March 22, 2024 13:36
@Serpentiel Serpentiel force-pushed the jeff-held-aiven-add-kube-version branch from f8b37db to a6fab25 Compare March 22, 2024 13:46
@Serpentiel Serpentiel marked this pull request as ready for review March 22, 2024 13:46
@Serpentiel Serpentiel requested a review from a team March 22, 2024 13:46
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Mar 22, 2024
@Serpentiel Serpentiel enabled auto-merge (squash) March 22, 2024 13:47
@Serpentiel Serpentiel merged commit aa9818d into main Mar 22, 2024
7 checks passed
@Serpentiel Serpentiel deleted the jeff-held-aiven-add-kube-version branch March 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants