Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(trunk): fix trunk fmt #639

Closed
wants to merge 1 commit into from
Closed

ci(trunk): fix trunk fmt #639

wants to merge 1 commit into from

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Feb 14, 2024 •
edited
Loading

trunk fmt damages markdown files.

@byashimov byashimov force-pushed the byashimov-remove-trunk-formatting branch from 8b51a50 to 3d70c76 Compare February 14, 2024 15:48
Serpentiel
Serpentiel suggested changes Feb 14, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@byashimov byashimov force-pushed the byashimov-remove-trunk-formatting branch from 3d70c76 to 90712e8 Compare February 14, 2024 16:01
@Serpentiel
Copy link
Contributor

I think this needs to be changed too to fix the YAML problem: https://github.com/aiven/aiven-operator/pull/639/files#diff-45a5a35dd7ad9a52d0fd3540f6c0d16a763575de51cc9a0a6c6f6a9f1da62ecdR29

@Serpentiel Serpentiel self-assigned this Feb 14, 2024
@Serpentiel Serpentiel added the bug Something isn't working label Feb 14, 2024
@Serpentiel Serpentiel changed the title fix(trunk): remove trunk formatting ci(trunk): fix trunk fmt Feb 14, 2024
@Serpentiel
Copy link
Contributor

Serpentiel commented Feb 14, 2024 •
edited
Loading

looks like we also need to exclude prettier for docs/**

also, maybe we should keep it like it was docs/docs/**, because the problem was actually that prettier was not disabled there

because there's a yaml file in docs/ that we might want to lint still

@byashimov byashimov closed this Feb 15, 2024
@byashimov byashimov deleted the byashimov-remove-trunk-formatting branch February 15, 2024 10:10
@Serpentiel
Copy link
Contributor

solved in #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel requested changes

Assignees

@Serpentiel Serpentiel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel