Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): log operation status when calling retryForever #636

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jeff-held-aiven
Copy link
Contributor

To better understand what exactly failed, retryForever now requires that a string that contains a description of the operation be passed.

@jeff-held-aiven jeff-held-aiven requested a review from a team February 14, 2024 11:31
@Serpentiel Serpentiel added the enhancement New feature or request label Feb 14, 2024
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-log-retries branch 2 times, most recently from 164244d to 8f16516 Compare February 14, 2024 16:14
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

To better understand what exactly failed, `retryForever` now requires
that a string that contains a description of the operation be passed.
@byashimov byashimov force-pushed the jeff-held-aiven-log-retries branch from 8f16516 to 5bcbebc Compare February 16, 2024 12:28
@byashimov byashimov enabled auto-merge (squash) February 16, 2024 12:28
@byashimov byashimov merged commit f69f4f6 into main Feb 16, 2024
7 checks passed
@byashimov byashimov deleted the jeff-held-aiven-log-retries branch February 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants