Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): expose CA certificate #634

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

byashimov
Copy link
Contributor

Exposes CA Certificate to secrets. Resolves #613

@byashimov byashimov force-pushed the byashimov-expose-ca-cert branch 6 times, most recently from c30465d to d6ebc91 Compare February 14, 2024 14:49
@byashimov byashimov marked this pull request as ready for review February 14, 2024 14:54
@byashimov byashimov requested a review from a team February 14, 2024 14:54
@byashimov byashimov force-pushed the byashimov-expose-ca-cert branch from d6ebc91 to 80f5451 Compare February 14, 2024 15:30
@jeff-held-aiven jeff-held-aiven self-assigned this Feb 15, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Feb 15, 2024
@byashimov byashimov force-pushed the byashimov-expose-ca-cert branch 2 times, most recently from 9ae1798 to 12b3e74 Compare February 15, 2024 10:18
Copy link
Contributor

@jeff-held-aiven jeff-held-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of questions that I'd like to discuss before approving

controllers/generic_service_handler.go Outdated Show resolved Hide resolved
@byashimov byashimov force-pushed the byashimov-expose-ca-cert branch from 12b3e74 to f1fd387 Compare February 16, 2024 12:30
@byashimov byashimov force-pushed the byashimov-expose-ca-cert branch from f1fd387 to 7641c7f Compare February 16, 2024 12:33
@jeff-held-aiven jeff-held-aiven merged commit 07b3ccd into main Feb 19, 2024
9 of 11 checks passed
@jeff-held-aiven jeff-held-aiven deleted the byashimov-expose-ca-cert branch February 19, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider putting the database CA certificate in the connection secret
3 participants