Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update KafkaTopicConfig #626

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

jeff-held-aiven
Copy link
Contributor

Allow for specifying the following fields:

  • local_retention_bytes
  • local_retention_ms
  • remote_storage_enable

@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-update-kafkatopicconfig branch 4 times, most recently from eb0722f to 5ced379 Compare February 9, 2024 09:49
@jeff-held-aiven jeff-held-aiven marked this pull request as ready for review February 9, 2024 10:54
@jeff-held-aiven jeff-held-aiven requested a review from a team February 9, 2024 10:54
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. It doesn't really send the values. Please take a look at this function.

@Serpentiel Serpentiel added the enhancement New feature or request label Feb 9, 2024
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-update-kafkatopicconfig branch from 5ced379 to a916c89 Compare February 12, 2024 09:55
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-update-kafkatopicconfig branch 2 times, most recently from 2587131 to 01840a6 Compare February 12, 2024 11:54
@byashimov
Copy link
Contributor

Tests are broken.

@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-update-kafkatopicconfig branch from 01840a6 to f3fc9f8 Compare February 14, 2024 11:04
Allow for specifying the following fields:

- local_retention_bytes
- local_retention_ms
- remote_storage_enable
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-update-kafkatopicconfig branch from f3fc9f8 to bfdf5b9 Compare February 14, 2024 14:50
@byashimov byashimov enabled auto-merge (squash) February 14, 2024 15:17
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byashimov byashimov merged commit e5bbfed into main Feb 14, 2024
7 checks passed
@byashimov byashimov deleted the jeff-held-aiven-update-kafkatopicconfig branch February 14, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants