feat(makefile): improve tool installation and kubebuilder asset installation process #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it easier to point IDE KUBEBUILDER_ASSETS env vars to the correct path. Previously, one would have to uncomment the `go test...` line in the `test` target to get kubebuilder assets installed in $LOCALBIN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goimportstarget, it was added in 5cc56e2 by me. As its not a versioned dependency, and it is very commonly used, we can expect that people familiar with go either a) already have it or b) know how to install itenvtesttarget. This makes it easier to setup IDE integrations to point to the correct KUBEBUILDER_ASSETS env var. Previously, the assets were installed on demand as part of thetesttarget. If one wanted to install kubebuilder assets they would have to either a) manually deduce the correct command and run it themselves ($PWD/bin/setup-envtest use 1.25.* --bin-dir $PWD/bin -p path) or b) uncomment thego test..command from thetesttarget to get the assets installed.