Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): add trunk linting setup #578

Merged
merged 8 commits into from
Dec 22, 2023
Merged

ci(lint): add trunk linting setup #578

merged 8 commits into from
Dec 22, 2023

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Dec 21, 2023

Best reviewed commit by commit.

  • run linting with trunk-io
  • add markdownlint check
  • add codespell check
  • add yamllint check
  • add hadolint check

Most of the diff is autofixed.

@rriski rriski requested review from a team and Serpentiel December 21, 2023 15:02
@rriski rriski mentioned this pull request Dec 21, 2023
Closed
Serpentiel
Serpentiel suggested changes Dec 21, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@Serpentiel
Copy link
Contributor

otherwise lgtm

@Serpentiel Serpentiel self-assigned this Dec 21, 2023
@Serpentiel Serpentiel added the enhancement New feature or request label Dec 21, 2023
@Serpentiel
Copy link
Contributor

Serpentiel commented Dec 21, 2023 •
edited
Loading

also please consider a different naming for the first commit/PR, feat makes sense in new product features most of the time, there are other good tags that work here, e.g. ci, build, etc.

@rriski rriski force-pushed the rriski-chore-lint-with-trunk branch from 9103e3c to e9dad89 Compare December 21, 2023 15:19
@rriski
Copy link
Contributor Author

rriski commented Dec 21, 2023

also please consider a different naming for the first commit/PR, feat makes sense in new product features most of the time, there are other good tags that work here, e.g. ci, build, etc.

Fixed the first commit message and removed if from github action

@rriski rriski requested a review from Serpentiel December 21, 2023 15:29
@Serpentiel Serpentiel changed the title feat(lint): add trunk linting setup ci(lint): add trunk linting setup Dec 21, 2023
Serpentiel
Serpentiel suggested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but cant merge because of commitlint

.github/workflows/lint.yml Outdated Show resolved Hide resolved
@rriski rriski force-pushed the rriski-chore-lint-with-trunk branch from e9dad89 to db5b9ef Compare December 22, 2023 07:41
@rriski rriski force-pushed the rriski-chore-lint-with-trunk branch from db5b9ef to 0cd3ff1 Compare December 22, 2023 07:42
@rriski rriski requested a review from Serpentiel December 22, 2023 07:43
Serpentiel
Serpentiel approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel merged commit 029a687 into main Dec 22, 2023
7 checks passed
@Serpentiel Serpentiel deleted the rriski-chore-lint-with-trunk branch December 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rriski @Serpentiel