Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka): expose schema registry and rest uris #563

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat(kafka): expose schema registry and rest uris #563

merged 1 commit into from
Dec 13, 2023

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Dec 12, 2023 •
edited
Loading

Expose KAFKA_SCHEMA_REGISTRY_URI and KAFKA_REST_URI to Kafka secret. Resolves #562

@byashimov byashimov force-pushed the byashimov-expose-kafka-uris branch from 01d0425 to dfd4cff Compare December 12, 2023 10:58
@byashimov byashimov changed the title chore(kafka): expose schema registry and rest uris fix(kafka): expose schema registry and rest uris Dec 12, 2023
@byashimov byashimov force-pushed the byashimov-expose-kafka-uris branch from dfd4cff to 1e6664f Compare December 13, 2023 12:10
@byashimov byashimov marked this pull request as ready for review December 13, 2023 12:10
@byashimov byashimov requested a review from a team December 13, 2023 12:10
@byashimov byashimov mentioned this pull request Dec 13, 2023
Merged
Serpentiel
Serpentiel approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Dec 13, 2023
@Serpentiel Serpentiel added the enhancement New feature or request label Dec 13, 2023
@Serpentiel Serpentiel changed the title fix(kafka): expose schema registry and rest uris feat(kafka): expose schema registry and rest uris Dec 13, 2023
@Serpentiel Serpentiel merged commit 133e58c into main Dec 13, 2023
6 checks passed
@Serpentiel Serpentiel deleted the byashimov-expose-kafka-uris branch December 13, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka secrets expose wrong for Service URI
2 participants
@byashimov @Serpentiel