Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connection_pool): expose pool name #561

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Dec 11, 2023

@byashimov byashimov requested a review from a team December 11, 2023 12:48
@byashimov byashimov marked this pull request as draft December 11, 2023 12:48
@byashimov byashimov force-pushed the byashimov-expose-connection-pool-name branch 3 times, most recently from 657422e to 9fadc69 Compare December 11, 2023 15:46
@byashimov
Copy link
Contributor Author

tests.

@byashimov byashimov marked this pull request as ready for review December 11, 2023 16:13
@Serpentiel Serpentiel added the enhancement New feature or request label Dec 12, 2023
ivan-savciuc
ivan-savciuc previously approved these changes Dec 13, 2023
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byashimov byashimov force-pushed the byashimov-expose-connection-pool-name branch from 9fadc69 to 1617cf2 Compare December 13, 2023 13:17
@byashimov byashimov enabled auto-merge (squash) December 13, 2023 13:35
@ivan-savciuc ivan-savciuc self-requested a review December 13, 2023 13:36
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byashimov byashimov merged commit 4c1702f into main Dec 13, 2023
6 checks passed
@byashimov byashimov deleted the byashimov-expose-connection-pool-name branch December 13, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connectionpool.connInfoSecretTarget does not expose CONNECTIONPOOL_NAME
3 participants