Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using aiven-operator in an argocd-setup where we heavily rely on status conditions for synchronization and monitoring purposes. After evaulating the operator we found two major issues:
Changes this PR introduces:
This pr builds on top of some of the work done in #101
I was reading the full discussion there as well as on the issue and i might not that i think it is not a good idea
to remove status conditions in the case the status resolves. I don't find this a standard practice in the whild and there
are good reasons for it. We would only hide that an error happened in the past and for everyone looking at the current
object it would still be clear that the object is healthy because we have a newer status condition then signaling that
the current state is indeed healthy.
Resolves: #66