Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return error from defer on object update #496

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: return error from defer on object update #496

merged 1 commit into from
Sep 14, 2023

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Sep 14, 2023 •
edited
Loading

Returns nil.

@byashimov byashimov requested a review from a team September 14, 2023 07:02
@byashimov byashimov added the bug Something isn't working label Sep 14, 2023
Serpentiel
Serpentiel approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Sep 14, 2023
@Serpentiel Serpentiel force-pushed the byashimov-fix-object-update-error branch from 212b35f to 39476df Compare September 14, 2023 07:48
@Serpentiel Serpentiel enabled auto-merge (squash) September 14, 2023 07:48
@Serpentiel Serpentiel merged commit e1dac2e into main Sep 14, 2023
6 checks passed
@Serpentiel Serpentiel deleted the byashimov-fix-object-update-error branch September 14, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel