fix: no_secret is inverted (#686)

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [MAJOR.MINOR.PATCH] - YYYY-MM-DD
 
 - Add `ClickhouseDatabase` kind
+- Fix secret creation for kinds with no secrets
 - Replace `Database` kind validations and default values with CRD validation rules
 - Perform upgrade tasks to check if PG service can be upgraded before updating the service
 - Expose project CA certificate to service secrets: `REDIS_CA_CERT`, `MYSQL_CA_CERT`, etc.

api/v1alpha1/clickhousedatabase_types.go

@@ -46,7 +46,7 @@ type ClickhouseDatabase struct {
 var _ AivenManagedObject = &ClickhouseDatabase{}
 
 func (*ClickhouseDatabase) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *ClickhouseDatabase) AuthSecretRef() *AuthSecretReference {

api/v1alpha1/database_types.go

@@ -63,7 +63,7 @@ type Database struct {
 var _ AivenManagedObject = &Database{}
 
 func (*Database) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *Database) AuthSecretRef() *AuthSecretReference {

api/v1alpha1/kafkaacl_types.go

@@ -68,7 +68,7 @@ func (in *KafkaACL) Conditions() *[]metav1.Condition {
 }
 
 func (*KafkaACL) NoSecret() bool {
-	return false
+	return true
 }
 
 // +kubebuilder:object:root=true

api/v1alpha1/kafkaconnect_types.go

@@ -35,7 +35,7 @@ type KafkaConnect struct {
 var _ AivenManagedObject = &KafkaConnect{}
 
 func (*KafkaConnect) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *KafkaConnect) AuthSecretRef() *AuthSecretReference {

api/v1alpha1/kafkaconnector_types.go

@@ -95,7 +95,7 @@ func (in *KafkaConnector) Conditions() *[]metav1.Condition {
 }
 
 func (*KafkaConnector) NoSecret() bool {
-	return false
+	return true
 }
 
 //+kubebuilder:object:root=true

api/v1alpha1/kafkaschema_types.go

@@ -61,7 +61,7 @@ type KafkaSchema struct {
 var _ AivenManagedObject = &KafkaSchema{}
 
 func (*KafkaSchema) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *KafkaSchema) AuthSecretRef() *AuthSecretReference {

api/v1alpha1/kafkatopic_types.go

@@ -185,7 +185,7 @@ func (in *KafkaTopic) Conditions() *[]metav1.Condition {
 }
 
 func (*KafkaTopic) NoSecret() bool {
-	return false
+	return true
 }
 
 // +kubebuilder:object:root=true

api/v1alpha1/projectvpc_types.go

@@ -59,7 +59,7 @@ type ProjectVPC struct {
 var _ AivenManagedObject = &ProjectVPC{}
 
 func (*ProjectVPC) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *ProjectVPC) AuthSecretRef() *AuthSecretReference {

api/v1alpha1/serviceintegration_types.go

@@ -123,7 +123,7 @@ type ServiceIntegration struct {
 var _ AivenManagedObject = &ServiceIntegration{}
 
 func (*ServiceIntegration) NoSecret() bool {
-	return false
+	return true
 }
 
 func (in *ServiceIntegration) AuthSecretRef() *AuthSecretReference {