fix(postgresql): no valid backups for read replica

aiven · Jul 16, 2024 · b6e42e0 · b6e42e0
1 parent 59691fa
commit b6e42e0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,15 +2,17 @@
 
 ## [MAJOR.MINOR.PATCH] - YYYY-MM-DD
 
+- Fix `PostgreSQL`: wait for a valid backup to create read replica
+- Fix `ClickhouseGrant`: grant privileges for an unknown table (Clickhouse can do that)
+- Fix `ClickhouseGrant`: track the state to revoke only known privileges
+
 ## v0.23.0 - 2024-07-12
 
 - Ignore `http.StatusBadRequest` on `ClickhouseGrant` deletion
 - Retry conflict error when k8s object saved to the storage
 - Fix `ClickhouseGrant` invalid remote and local privileges comparison
 - Fix `ClickhouseGrant`: doesn't escape role name to grant
 - Fix `ClickhouseUser`: password was reset due to an incorrect processing cycle
-- Fix `ClickhouseGrant`: grant privileges for an unknown table (Clickhouse can do that)
-- Fix `ClickhouseGrant`: track the state to revoke only known privileges
 
 ## v0.22.0 - 2024-07-02
 

diff --git a/controllers/generic_service_handler.go b/controllers/generic_service_handler.go
@@ -236,6 +236,12 @@ func (h *genericServiceHandler) checkPreconditions(ctx context.Context, avn *aiv
 			if !r || err != nil {
 				return false, err
 			}
+
+			// Covers error "No valid backups for service"
+			list, err := avnGen.ServiceBackupsGet(ctx, spec.Project, s.SourceServiceName)
+			if len(list) == 0 || err != nil {
+				return false, err
+			}
 		}
 	}
 	return true, nil