Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(makefile): install
goimports
to (LOCALBIN)
If `goimports` wasn't installed, `make build` would fail with: ❯ make build go generate ./... 2023/12/18 11:45:04 can't compile field "topic_name" regex `^(?!\.$|\.\.$)[-_.A-Za-z0-9]+$`: error parsing regexp: invalid or unsupported Perl syntax: `(?!` 2023/12/18 11:45:04 can't compile field "name" regex `^(?!\.$|\.\.$)[-_.A-Za-z0-9]+$`: error parsing regexp: invalid or unsupported Perl syntax: `(?!` 2023/12/18 11:45:04 can't compile field "tag" regex `^(?!aiven-)[^\W\d_](?:[:\w./-]*[\w./-])?$`: error parsing regexp: invalid or unsupported Perl syntax: `(?!` 2023/12/18 11:45:04 can't compile field "kafka_topic" regex `^(?!\.$|\.\.$)[-_.A-Za-z0-9]+$`: error parsing regexp: invalid or unsupported Perl syntax: `(?!` test -s /Users/riski/code/work/aiven-operator/bin/controller-gen || GOBIN=/Users/riski/code/work/aiven-operator/bin go install sigs.k8s.io/controller-tools/cmd/[email protected] /Users/riski/code/work/aiven-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..." find . -type f -name '*.go' -exec sed -zi 's/"\n\+\t"/"\n"/g' {} + goimports -local "github.com/aiven/aiven-operator" -w . bash: line 1: goimports: command not found make: *** [Makefile:352: imports] Error 127 This commit adds a new target to the makefile which downloads `goimports` to `$(LOCALBIN)` if necessary.
- Loading branch information