Skip to content

Commit

Permalink
fix(tests): shorter service names in connection secret tests (#608)
Browse files Browse the repository at this point in the history
  • Loading branch information
rriski authored Jan 26, 2024
1 parent 00d48c6 commit 0376caa
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/service_opts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func TestServiceConnInfoSecretTargetDisabled(t *testing.T) {
// Modifying `connInfoSecretTargetDisabled` from missing to true --> A secret is created, but the update fails
// because `connInfoSecretTargetDisabled` can only be set during resource creation.
testName: "modify from missing to true",
serviceName: randName("grafana-modify-conn-info-secret-target-disabled-from-missing-to-true"),
serviceName: randName("grafana-conn-secret-test-1"),
connInfoSecretTargetDisabledChange: []*bool{nil, pointer.Bool(true)},
expectSecretGetErrIsNil: true,
expectSecretIsNil: false,
Expand All @@ -165,7 +165,7 @@ func TestServiceConnInfoSecretTargetDisabled(t *testing.T) {
// Modifying `connInfoSecretTargetDisabled` from true to missing --> A secret is not created and the update fails
// because `connInfoSecretTargetDisabled` can only be set during resource creation.
testName: "modify from true to missing",
serviceName: randName("grafana-modify-conn-info-secret-target-disabled-from-true-to-missing"),
serviceName: randName("grafana-conn-secret-test-2"),
connInfoSecretTargetDisabledChange: []*bool{pointer.Bool(true), nil},
expectSecretGetErrIsNil: false,
expectSecretIsNil: true,
Expand All @@ -175,7 +175,7 @@ func TestServiceConnInfoSecretTargetDisabled(t *testing.T) {
// Modifying `connInfoSecretTargetDisabled` from false to true --> A secret is created and the update fails
// due to the immutability of `connInfoSecretTargetDisabled`.
testName: "modify from false to true",
serviceName: randName("grafana-modify-conn-info-secret-target-disabled-from-false-to-true"),
serviceName: randName("grafana-conn-secret-test-3"),
connInfoSecretTargetDisabledChange: []*bool{pointer.Bool(false), pointer.Bool(true)},
expectSecretGetErrIsNil: true,
expectSecretIsNil: false,
Expand Down

0 comments on commit 0376caa

Please sign in to comment.