Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Valkey users #354

Closed
wants to merge 1 commit into from
Closed

Conversation

bogdanp05
Copy link
Contributor

With the release of Aiven for Valkey, it's possible to create Valkey ACL users via the API. This PR adds the required fields to AccessControl.

@bogdanp05 bogdanp05 requested a review from a team as a code owner July 8, 2024 06:26
@bogdanp05 bogdanp05 requested a review from a team July 8, 2024 06:30
@byashimov
Copy link
Contributor

Hey. Thanks for the contribution!
This change has been automatically delivered to the code-generated client aiven/go-client-codegen@149e780#diff-48bfae2c1b90bdc20b7ef17dedbbb4444f5b32c7881d651352aea137b9b812bcR531
Do you still need your changes in this rep? We try to not use this client, except exceptional cases :)

@bogdanp05
Copy link
Contributor Author

@byashimov Oh nice! I didn't know about the generated client. I have couple of follow-up questions:

  • I see the aiven terraform provider uses both the generated client and this client. I'm guessing it's possible to add a resource for Valkey only with the generated client?
  • Are we planning to deprecate this client eventually in favor of the generated one?

If the answer is yes for both questions, I can close this PR.

@byashimov
Copy link
Contributor

byashimov commented Jul 8, 2024

Hey. We use both clients because there are parts of the API that still can't be generated. But, yes, we plan to deprecate this client.
Regarding the terraform, unfortunately this part has no generation. Please make a ticket in jira for this feature. Thanks 🙏

@bogdanp05
Copy link
Contributor Author

Thanks, makes sense, closing.

@bogdanp05 bogdanp05 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants