Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka_topic): config to read #326

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(kafka_topic): config to read #326

merged 1 commit into from
Jan 11, 2024
+29 −30

Conversation

byashimov
Copy link
Contributor

Marks nullable objects.

@byashimov byashimov force-pushed the byashimov-fix-kafka-topic-config-read branch from 70495cc to b453591 Compare January 10, 2024 10:30
@byashimov
Copy link
Contributor Author

TF tests.

@byashimov byashimov force-pushed the byashimov-fix-kafka-topic-config-read branch from b453591 to 01b47b3 Compare January 11, 2024 11:53
@byashimov byashimov marked this pull request as ready for review January 11, 2024 11:53
@byashimov byashimov requested a review from a team January 11, 2024 11:53
ivan-savciuc
ivan-savciuc approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byashimov byashimov merged commit b212bc7 into main Jan 11, 2024
4 checks passed
@byashimov byashimov deleted the byashimov-fix-kafka-topic-config-read branch January 11, 2024 12:17
@Serpentiel Serpentiel added the bug label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-savciuc ivan-savciuc ivan-savciuc approved these changes

Assignees

@byashimov byashimov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byashimov @ivan-savciuc @Serpentiel