Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): expose tech_emails in Service #319

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat(service): expose tech_emails in Service #319

merged 1 commit into from
Dec 21, 2023
+3 −0

Conversation

jeff-held-aiven
Copy link
Contributor

@jeff-held-aiven jeff-held-aiven commented Dec 13, 2023 •
edited
Loading

No description provided.

@jeff-held-aiven jeff-held-aiven requested a review from a team December 13, 2023 08:28
@Serpentiel Serpentiel self-assigned this Dec 13, 2023
Serpentiel
Serpentiel reviewed Dec 13, 2023
View reviewed changes
service_test.go Outdated Show resolved Hide resolved
@Serpentiel Serpentiel removed their assignment Dec 13, 2023
byashimov
byashimov requested changes Dec 13, 2023
View reviewed changes
service.go Show resolved Hide resolved
service_test.go Outdated Show resolved Hide resolved
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch 3 times, most recently from 31530ef to efec2a6 Compare December 13, 2023 13:02
@jeff-held-aiven jeff-held-aiven marked this pull request as draft December 13, 2023 13:04
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from efec2a6 to 6d73280 Compare December 14, 2023 13:29
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from 6d73280 to 4298c57 Compare December 15, 2023 14:14
@jeff-held-aiven jeff-held-aiven marked this pull request as ready for review December 21, 2023 11:27
@jeff-held-aiven jeff-held-aiven requested a review from a team December 21, 2023 11:27
byashimov
byashimov approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byashimov byashimov merged commit 62a14b2 into main Dec 21, 2023
4 checks passed
@byashimov byashimov deleted the jeff-held-aiven-service-tech-emails branch December 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel left review comments

@byashimov byashimov byashimov approved these changes

Assignees

@byashimov byashimov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-held-aiven @byashimov @Serpentiel