Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: compatibility as a go mod dependency #313

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Serpentiel
Copy link
Contributor

currently, it's not possible to install aiven-go-client v2 as a dependency because of the following error:

go: github.com/aiven/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/aiven/aiven-go-client/v2")

this PR addresses this issue, see https://donatstudios.com/Go-v2-Modules for more information

@Serpentiel Serpentiel requested a review from a team September 13, 2023 23:21
byashimov
byashimov previously approved these changes Sep 14, 2023
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Sep 14, 2023
@Serpentiel Serpentiel force-pushed the aleks-chore-compatibility-as-a-go-mod-dependency branch from 3c5b6db to dfd514f Compare September 14, 2023 07:46
byashimov

This comment was marked as off-topic.

@byashimov byashimov merged commit c00cc28 into main Sep 14, 2023
4 checks passed
@byashimov byashimov deleted the aleks-chore-compatibility-as-a-go-mod-dependency branch September 14, 2023 08:15
@Serpentiel Serpentiel assigned byashimov and unassigned Serpentiel Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants