Merge pull request #48 from aiven/0xlianhu-BF-2380-prune-stuck-when-l…

…ost-migration-source

Add parameter to pg_drop_subscription to specify if drop replication slot together

Makefile

@@ -1,5 +1,5 @@
-short_ver = 1.1.10
-last_ver = 1.1.9
+short_ver = 1.1.11
+last_ver = 1.1.10
 long_ver = $(shell git describe --long 2>/dev/null || echo $(short_ver)-0-unknown-g`git describe --always`)
 generated = aiven_extras.control \
 			sql/aiven_extras--$(short_ver).sql \

sql/aiven_extras--1.1.9--1.1.10.sql

@@ -0,0 +1 @@
+-- NOOP

sql/aiven_extras.sql

@@ -170,8 +170,10 @@ END;
 $$;
 
 DROP FUNCTION IF EXISTS aiven_extras.pg_drop_subscription(TEXT);
+DROP FUNCTION IF EXISTS aiven_extras.pg_drop_subscription(TEXT, BOOLEAN);
 CREATE FUNCTION aiven_extras.pg_drop_subscription(
-    arg_subscription_name TEXT
+    arg_subscription_name TEXT,
+    arg_drop_repl_slot BOOLEAN = TRUE
 )
 RETURNS VOID LANGUAGE plpgsql
 SECURITY DEFINER
@@ -191,7 +193,9 @@ BEGIN
     EXECUTE pg_catalog.format('ALTER SUBSCRIPTION %I DISABLE', arg_subscription_name);
     EXECUTE pg_catalog.format('ALTER SUBSCRIPTION %I SET (slot_name = NONE)', arg_subscription_name);
     EXECUTE pg_catalog.format('DROP SUBSCRIPTION %I', arg_subscription_name);
-    PERFORM aiven_extras.dblink_slot_create_or_drop(l_subconninfo, l_slot_name, 'drop');
+    IF (arg_drop_repl_slot IS TRUE) THEN
+        PERFORM aiven_extras.dblink_slot_create_or_drop(l_subconninfo, l_slot_name, 'drop');
+    END IF;
 END;
 $$;