Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting source and target uris as environment variables #55

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ettanany
Copy link
Contributor

@ettanany ettanany commented Aug 20, 2024

Proposed changes in this pull request

Currently, source and target URIs are passed as command-line arguments. With this change, we now also support supplying them as environment variables.

Type (put an x where ever applicable)

  • Bug fix: Link to the issue
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement
  • Other

Checklist

Please put an x against the checkboxes. Write a small comment explaining if its N/A (not applicable)

  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable (in code and README.md).

Optional extra information

@ettanany ettanany force-pushed the ettanany-set-source-and-traget-uris-as-env-vars branch 2 times, most recently from d020fc4 to 77477da Compare August 20, 2024 17:06
@ettanany ettanany force-pushed the ettanany-set-source-and-traget-uris-as-env-vars branch from 77477da to a85bc4e Compare August 21, 2024 07:26
@ettanany ettanany marked this pull request as ready for review August 21, 2024 15:53
@ettanany ettanany requested a review from a team as a code owner August 21, 2024 15:53
@alexole alexole merged commit 0578850 into main Aug 22, 2024
12 checks passed
@alexole alexole deleted the ettanany-set-source-and-traget-uris-as-env-vars branch August 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants