Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-253] Add Github Actions #2328

Merged
merged 23 commits into from
Aug 12, 2024
Merged

[PE-253] Add Github Actions #2328

merged 23 commits into from
Aug 12, 2024

Conversation

Synicalx
Copy link

Description, Motivation and Context

  • Migrating this repo away from CircleCI
  • Step 1 here is adding the Github Actions config
  • Note: this is currently set to run on all PR's so it can be tested here prior to merging, this will need to be changed in a subsequent PR

Checklist:

  • I've added/updated tests to cover my changes
  • I've created an issue associated with this PR

@Synicalx Synicalx changed the title create github action replacements for cci config [PE-253] Add Github Actions Jul 22, 2024
Zac Boyd added 20 commits July 22, 2024 14:56
add paths for node cache
8e12482
remove references to node image
da3bbb3
convert circleci tests
4c4fc02
swap to runson runners for tests
64dfc98
bump runner size to handle simultaneous tests better
eb835a9
update test action to account for junit output, make junit output fil…
1d8f11e 
…enames more unique
minor syntax fixes, correct artifact path for test summary
2e0795b
syntax changes for consistency
0196baa
add step to ensure junit output directory exists
7ffb953
change test summary file path to wildcard filenames
b32d511
update test summary step, make optional
6a8b96b
minor fix for test summary path
a8fa904
remove test summary step temporarily
3675feb
swap test upload step to main CI workflow
baae3e8
remove duplicate step, make artifact names more unique
2f3b3e7
fix path for npmrc
d6d6dbe
add sharding to speed up yarn tests
53999d3
fix naming for shards
7fc66b5
reduce shards, move test summary to the end of the job so it only pro…
86e1dfb 
…duces one summary instead of several
run only on master, and publish
431d7c8
@Synicalx Synicalx marked this pull request as ready for review August 5, 2024 01:31
@Synicalx Synicalx requested a review from a team as a code owner August 5, 2024 01:31
@Synicalx Synicalx requested review from timdawborn and vlj91 August 5, 2024 01:31
vlj91
vlj91 previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@vlj91 vlj91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the conditional on the publish job

.github/workflows/build-and-test.yml Show resolved Hide resolved
@Synicalx Synicalx removed the request for review from timdawborn August 8, 2024 02:35
@Synicalx Synicalx requested a review from flavray August 8, 2024 02:35
timdawborn
timdawborn reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@timdawborn timdawborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the fact that this PR is missing dependabot configurations for both of the actions and the workflows.

@vlj91 vlj91 requested review from timdawborn and vlj91 August 12, 2024 00:54
timdawborn
timdawborn approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@timdawborn timdawborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Synicalx Synicalx enabled auto-merge (squash) August 12, 2024 04:11
@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Synicalx Synicalx merged commit 2049c9f into master Aug 12, 2024
25 checks passed
@Synicalx Synicalx deleted the PE-253-migrate-to-github-actions branch August 12, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlj91 vlj91 vlj91 approved these changes

@timdawborn timdawborn timdawborn approved these changes

@flavray flavray Awaiting requested review from flavray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Synicalx @CLAassistant @timdawborn @vlj91