Remove all usage of unsafe casts (outside of tests) (#108)

This looks like a big diff because of Prettier, but all it's doing is changing `a.reduce(..., {} as T)` to `a.reduce<T>(..., {})` 😄
airtasker · Feb 21, 2019 · 9634463 · 9634463
1 parent f1e897b
commit 9634463
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 78 deletions.
diff --git a/lib/src/generators/contract/openapi2.ts b/lib/src/generators/contract/openapi2.ts
@@ -44,35 +44,32 @@ export function openApiV2(contractDefinition: ContractDefinition): OpenApiV2 {
         name: "TODO"
       }
     },
-    paths: contractDefinition.endpoints.reduce(
-      (acc, endpoint) => {
-        const openApiPath = endpoint.path.replace(/:(\w+)/g, "{$1}");
-        acc[openApiPath] = acc[openApiPath] || {};
-        acc[openApiPath][endpoint.method.toLowerCase()] = {
-          operationId: endpoint.name,
-          description: endpoint.description,
-          tags: endpoint.tags,
-          parameters: getParameters(endpoint),
-          responses: {
-            ...(endpoint.defaultResponse
-              ? { default: response(endpoint.defaultResponse) }
-              : {}),
-            ...endpoint.responses.reduce<{
-              [statusCode: string]: OpenAPIV2Response;
-            }>((acc, responseNode) => {
-              acc[responseNode.status.toString(10)] = response(responseNode);
-              return acc;
-            }, {})
-          }
-        };
-        return acc;
-      },
-      {} as {
-        [endpointPath: string]: {
-          [method: string]: OpenAPIV2Operation;
-        };
-      }
-    ),
+    paths: contractDefinition.endpoints.reduce<{
+      [endpointPath: string]: {
+        [method: string]: OpenAPIV2Operation;
+      };
+    }>((acc, endpoint) => {
+      const openApiPath = endpoint.path.replace(/:(\w+)/g, "{$1}");
+      acc[openApiPath] = acc[openApiPath] || {};
+      acc[openApiPath][endpoint.method.toLowerCase()] = {
+        operationId: endpoint.name,
+        description: endpoint.description,
+        tags: endpoint.tags,
+        parameters: getParameters(endpoint),
+        responses: {
+          ...(endpoint.defaultResponse
+            ? { default: response(endpoint.defaultResponse) }
+            : {}),
+          ...endpoint.responses.reduce<{
+            [statusCode: string]: OpenAPIV2Response;
+          }>((acc, responseNode) => {
+            acc[responseNode.status.toString(10)] = response(responseNode);
+            return acc;
+          }, {})
+        }
+      };
+      return acc;
+    }, {}),
     definitions: contractDefinition.types.reduce<{
       [typeName: string]: OpenAPI2SchemaType;
     }>((acc, typeNode) => {

diff --git a/lib/src/generators/contract/openapi3.ts b/lib/src/generators/contract/openapi3.ts
@@ -49,56 +49,53 @@ export function openApiV3(contractDefinition: ContractDefinition): OpenApiV3 {
           ]
         }
       : {}),
-    paths: contractDefinition.endpoints.reduce(
-      (acc, endpoint) => {
-        const openApiPath = endpoint.path.replace(/:(\w+)/g, "{$1}");
-        acc[openApiPath] = acc[openApiPath] || {};
-        acc[openApiPath][endpoint.method.toLowerCase()] = {
-          operationId: endpoint.name,
-          description: endpoint.description,
-          tags: endpoint.tags,
-          parameters: getParameters(contractDefinition.types, endpoint),
-          ...(endpoint.request.body && {
-            requestBody: {
-              content: {
-                "application/json": {
-                  schema: openApi3TypeSchema(
-                    contractDefinition.types,
-                    endpoint.request.body.type
-                  )
-                }
-              },
-              description: endpoint.description || ""
-            }
-          }),
-          responses: {
-            ...(endpoint.defaultResponse
-              ? {
-                  default: response(
-                    contractDefinition.types,
-                    endpoint.defaultResponse
-                  )
-                }
-              : {}),
-            ...endpoint.responses.reduce<{
-              [statusCode: string]: OpenAPIV3Body;
-            }>((acc, responseNode) => {
-              acc[responseNode.status.toString(10)] = response(
-                contractDefinition.types,
-                responseNode
-              );
-              return acc;
-            }, {})
+    paths: contractDefinition.endpoints.reduce<{
+      [endpointPath: string]: {
+        [method: string]: OpenAPIV3Operation;
+      };
+    }>((acc, endpoint) => {
+      const openApiPath = endpoint.path.replace(/:(\w+)/g, "{$1}");
+      acc[openApiPath] = acc[openApiPath] || {};
+      acc[openApiPath][endpoint.method.toLowerCase()] = {
+        operationId: endpoint.name,
+        description: endpoint.description,
+        tags: endpoint.tags,
+        parameters: getParameters(contractDefinition.types, endpoint),
+        ...(endpoint.request.body && {
+          requestBody: {
+            content: {
+              "application/json": {
+                schema: openApi3TypeSchema(
+                  contractDefinition.types,
+                  endpoint.request.body.type
+                )
+              }
+            },
+            description: endpoint.description || ""
           }
-        };
-        return acc;
-      },
-      {} as {
-        [endpointPath: string]: {
-          [method: string]: OpenAPIV3Operation;
-        };
-      }
-    ),
+        }),
+        responses: {
+          ...(endpoint.defaultResponse
+            ? {
+                default: response(
+                  contractDefinition.types,
+                  endpoint.defaultResponse
+                )
+              }
+            : {}),
+          ...endpoint.responses.reduce<{
+            [statusCode: string]: OpenAPIV3Body;
+          }>((acc, responseNode) => {
+            acc[responseNode.status.toString(10)] = response(
+              contractDefinition.types,
+              responseNode
+            );
+            return acc;
+          }, {})
+        }
+      };
+      return acc;
+    }, {}),
     components: {
       schemas: contractDefinition.types.reduce<{
         [typeName: string]: OpenAPI3SchemaType;