-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves all CI to GitHub Actions #610
Conversation
.github/workflows/ci.yml
Outdated
- name: Authenticate with npm registry | ||
run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPMJS_PUBLISH_TOKEN }}" > ~/.npmrc | ||
|
||
- name: Publish to npm registry | ||
run: npm publish --access=public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: It looks like there's a more canonical way to do this in GHA: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
lint
,build
, andpublish
. There is a slight change in that we now always run thelint
andbuild
stepslint
,build
, andpublish
steps using the Node version in.nvmrc
, rather than explicitly using Node 14 as we did in CircleCIOnce approved, I'll disable CircleCI prior to merging.