Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in GitHub Actions #608

Merged
merged 3 commits into from
May 16, 2024
Merged

Run tests in GitHub Actions #608

merged 3 commits into from
May 16, 2024

Conversation

vlj91
Copy link
Contributor

@vlj91 vlj91 commented May 16, 2024 •
edited
Loading

  • Runs the test suite in GitHub Actions
  • Adds Dependabot configuration for GitHub Actions

CircleCI configuration will be removed later, for now we can run the tests in both CircleCI and GitHub Actions.

@CLAassistant
Copy link

CLAassistant commented May 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vlj91 vlj91 self-assigned this May 16, 2024
@vlj91 vlj91 marked this pull request as ready for review May 16, 2024 02:24
@vlj91 vlj91 requested a review from a team as a code owner May 16, 2024 02:24
@vlj91 vlj91 requested review from njday and timdawborn May 16, 2024 02:24
timdawborn
timdawborn approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@timdawborn timdawborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Confirming that this is not everything in the CircleCI file though. build-and-run, lint-check, and publish aren't in this PR.

@vlj91
Copy link
Contributor Author

vlj91 commented May 16, 2024

LGTM 👍

Confirming that this is not everything in the CircleCI file though. build-and-run, lint-check, and publish aren't in this PR.

Yup, those will come later 👍

@vlj91 vlj91 merged commit c117698 into master May 16, 2024
12 checks passed
@vlj91 vlj91 deleted the test-in-github-actions branch May 16, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdawborn timdawborn timdawborn approved these changes

@njday njday Awaiting requested review from njday njday is a code owner automatically assigned from airtasker/platform-services-core

Assignees

@vlj91 vlj91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlj91 @CLAassistant @timdawborn