Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EC implementation #137

Merged
3 commits merged into from
Jan 23, 2019
Merged

Improve EC implementation #137

3 commits merged into from
Jan 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2019

Some minor improvements regarding the EC implementation in #88. Mainly the fix needed until we merge #120 to ignore non-string JWK parameters.

We can release 1.5.0 after merging this.

@ghost ghost self-requested a review January 22, 2019 10:38
@ghost ghost self-assigned this Jan 22, 2019
@ghost ghost changed the title EC key improvements Improve EC implementation Jan 22, 2019
Copy link
Contributor

@carol-mohemian carol-mohemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, GNTM 💃 👏

Copy link
Contributor

@markus-mohemian markus-mohemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

Copy link
Contributor

@markus-mohemian markus-mohemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

@ghost ghost merged commit 4923622 into master Jan 23, 2019
@ghost ghost deleted the fixes/88-updates branch January 23, 2019 09:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants