Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-gate playbook does not evaluate MACs and bootMode properly. #648

Open
patilsuraj767 opened this issue Sep 30, 2021 · 3 comments
Open

build-gate playbook does not evaluate MACs and bootMode properly. #648

patilsuraj767 opened this issue Sep 30, 2021 · 3 comments
Assignees
@patilsuraj767
Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Milestone
v2.2

Comments

@patilsuraj767
Copy link
Contributor

Describe the bug
In airship-airshipctl-build-gate.yml - here we only consider hosts in ephemeral/controlplane and not from target/controlplane.
Also, get-vm-config.yaml will fail at this point - here when we will specify more than one host in ephemeral/controlplane because it will every time override target_vm_cfg ansible fact instead of appending to it.

Steps To Reproduce
Try to create kubernetes cluster with 3 controlplane by adding more nodes in target/controlplane/hostgenerator.
10_build_gate.sh fails to create the VMs with proper configuration.

Expected behavior
libvirt VMs should get created with specified configuration.
@patilsuraj767 patilsuraj767 added bug Something isn't working triage Needs evaluation by project members labels Sep 30, 2021
@patilsuraj767
Copy link
Contributor Author

Please assign this issue to me.

@patilsuraj767 patilsuraj767 mentioned this issue Oct 1, 2021
Open
@mattmceuen
Copy link
Contributor

This relates to an issue that @ian-howell is planning to create to make AIAP able to use a non-default, multi-node infra build container; that one would have a dependency on this one. So I think this is a good one to try to tackle soon and ensure the playbooks are agnostic to the number of nodes that are use in a test setup.

@mattmceuen mattmceuen removed the triage Needs evaluation by project members label Oct 6, 2021
@mattmceuen mattmceuen added this to the v2.2 milestone Oct 6, 2021
@mattmceuen mattmceuen added the priority/critical Items critical to be implemented, usually by the next release label Oct 6, 2021
This was referenced Oct 6, 2021
Open
Closed
@patilsuraj767
Copy link
Contributor Author

I have patch-set ready for this. - https://review.opendev.org/c/airship/airshipctl/+/812100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patilsuraj767 patilsuraj767

Labels
bug Something isn't working priority/critical Items critical to be implemented, usually by the next release
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@mattmceuen @patilsuraj767