Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-gate playbook does not evaluate MACs and bootMode properly. #202

Open
patilsuraj767 opened this issue Oct 1, 2021 · 2 comments
Open
Labels
bug Something isn't working design needed Requires design approach/discussion
Milestone

Comments

@patilsuraj767
Copy link

Copy of issue from airshipctl. Same applies to treasuremap. - airshipit/airshipctl#648

Describe the bug
In airship-airshipctl-build-gate.yml - here we only consider hosts in ephemeral/controlplane and not from target/controlplane.
Also, get-vm-config.yaml will fail at this point - here when we will specify more than one host in ephemeral/controlplane because it will every time override target_vm_cfg ansible fact instead of appending to it.

Steps To Reproduce
Try to create kubernetes cluster with 3 controlplane by adding more nodes in target/controlplane/hostgenerator.
10_build_gate.sh fails to create the VMs with proper configuration.

Expected behavior
libvirt VMs should get created with specified configuration.

@patilsuraj767 patilsuraj767 added bug Something isn't working triage labels Oct 1, 2021
@mattmceuen mattmceuen added design needed Requires design approach/discussion and removed triage labels Oct 6, 2021
@mattmceuen mattmceuen added this to the Future milestone Oct 6, 2021
@mattmceuen
Copy link
Contributor

Marking this as "design needed" because we need to have the conversation around whether we keep treasuremap, and if so how it'll fit into things. This will occur at the PTG in a couple weeks; let's hold on this one for now @patilsuraj767

@patilsuraj767
Copy link
Author

Ok, Thanks @mattmceuen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design needed Requires design approach/discussion
Projects
None yet
Development

No branches or pull requests

2 participants