update mmseg and mmdet configs according to the installed versions

airctic · Oct 2, 2023 · 728c985 · 728c985
1 parent f2b979a
commit 728c985
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/icevision/models/mmdet/download_configs.py b/icevision/models/mmdet/download_configs.py
@@ -3,7 +3,7 @@
 from icevision.imports import *
 from icevision.utils import *
 
-VERSION = "v2.20.1"
+VERSION = "v2.25.0"
 BASE_URL = "https://github.com/airctic/mmdetection_configs/archive/refs/tags"
 
 
@@ -15,7 +15,7 @@ def download_mmdet_configs() -> Path:
 
     if mmdet_config_path.exists():
         logger.info(
-            f"The mmdet config folder already exists. No need to downloaded it. Path : {mmdet_config_path}"
+            f"The mmdet config folder already exists. No need to download it. Path : {mmdet_config_path}"
         )
     elif download_path.exists():
         # The zip file was downloaded by not extracted yet

diff --git a/icevision/models/mmseg/download_configs.py b/icevision/models/mmseg/download_configs.py
@@ -3,34 +3,32 @@
 from icevision.imports import *
 from icevision.utils import *
 
-# VERSION = "v2.10.0"  # TODO: Update
-VERSION = "v0.17.0"
-BASE_URL = "https://codeload.github.com/Orbis-International/mmsegmentation_configs/zip/refs/tags"
+VERSION = "0.29.1"
+BASE_URL = f"https://github.com/potipot/icevision/releases/download/0.13.0/mmsegmentation_configs-{VERSION}.zip"
 
 
 def download_mmseg_configs() -> Path:
 
     save_dir = get_root_dir() / f"mmsegmentation_configs"
 
-    mmseg_config_path = save_dir / f"mmsegmentation_configs-{VERSION[1:]}/configs"
-    download_path = save_dir / f"{VERSION}.zip"
+    mmseg_config_path = save_dir / Path(BASE_URL).stem / "configs"
+    download_path = save_dir / f"{Path(BASE_URL).stem}.zip"
 
     if mmseg_config_path.exists():
         logger.info(
-            f"The mmseg config folder already exists. No need to downloaded it. Path : {mmseg_config_path}"
+            f"The mmseg config folder already exists. No need to download it. Path : {mmseg_config_path}"
         )
     elif download_path.exists():
         # The zip file was downloaded by not extracted yet
         # Extract zip file
-        logger.info(f"Extracting the {VERSION}.zip file.")
+        logger.info(f"Extracting the {download_path.name} file.")
         save_dir = Path(download_path).parent
         shutil.unpack_archive(filename=str(download_path), extract_dir=str(save_dir))
     else:
         save_dir.mkdir(parents=True, exist_ok=True)
 
-        download_path = save_dir / f"{VERSION}.zip"
         if not download_path.exists():
             logger.info("Downloading mmseg configs")
-            download_and_extract(f"{BASE_URL}/{VERSION}", download_path)
+            download_and_extract(BASE_URL, download_path)
 
     return mmseg_config_path